Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Chat Trigger Node): Fix public chat container dimensions #9664

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix(Chat Trigger Node): Fix public chat container dimensions #9664

merged 1 commit into from
Jun 7, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

Set width & height to 100% for the public chat container to fix scrolling & sizing issues

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@OlegIvaniv
fix(Chat Trigger Node): Fix public chat container dimensions
d62e9d2 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 7, 2024
@cypress Cypress
Copy link

cypress bot commented Jun 7, 2024

2 flaky tests on run #5356 ↗︎

0 362 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: d62e9d2a3f
Status: Passed Duration: 05:15 💡
Started: Jun 7, 2024 9:29 AM Ended: Jun 7, 2024 9:34 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9664 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 3b10c0f into master Jun 7, 2024
28 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-194-public-workflow-chat-scroll-issues branch June 7, 2024 09:47
RicardoE105 pushed a commit that referenced this pull request Jun 9, 2024
@OlegIvaniv @RicardoE105
fix(Chat Trigger Node): Fix public chat container dimensions (#9664)
39ddaac 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Merged
@janober
Copy link
Member

janober commented Jun 12, 2024

Got released with n8n@1.46.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-radency michael-radency michael-radency approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegIvaniv @janober @michael-radency